Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues on #26 #30

Closed
wants to merge 3 commits into from
Closed

Fixing issues on #26 #30

wants to merge 3 commits into from

Conversation

syedautherabbas
Copy link

No description provided.

@antoniolofiego antoniolofiego changed the base branch from main to staging July 28, 2020 00:55
@antoniolofiego
Copy link
Collaborator

The base branch target was wrong, fixed it to staging.

@antoniolofiego antoniolofiego added the enhancement New feature or request label Jul 28, 2020
antoniolofiego
antoniolofiego reviewed Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@antoniolofiego antoniolofiego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, much cleaner handling of the DDB calls! Have not had a chance to test locally yet, but I will do so as soon as possible. I will wait to merge until we have the CI pipeline in place to automate the tests and this passes.

test_API/test_get_user_by_Id/test_get_user_by_ID.py Outdated Show resolved Hide resolved
@what-name
Copy link
Collaborator

Looks great! Please put __pycache__ into .gitignore and it can get merged.

@antoniolofiego
Copy link
Collaborator

Looks great! Please put __pycache__ into .gitignore and it can get merged.

Please, look at #27 before merging anything. We need to set up automated testing before merging new things.

@antoniolofiego antoniolofiego added this to the Backend milestone Jul 28, 2020
@what-name
Copy link
Collaborator

Close due to migration of the whole staging branch to 100DaysOfCloudBackend.

@syedautherabbas please remove the __pycache__ folder and resubmit this PR to the new repo after it has been populated.

@what-name what-name closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniolofiego antoniolofiego antoniolofiego left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backend transition
Development

Successfully merging this pull request may close these issues.
3 participants
@syedautherabbas @antoniolofiego @what-name