-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote the name of the maybe/2 type #10
Open
kivra-pergus
wants to merge
86
commits into
0xYUANTI:master
Choose a base branch
from
kivra:'maybe'_notmaybe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add luhn implementation
Add s2_math with ceiling and floor functions.
Ifdef all tests
Add histogram for kivra metrics
* This will also enable warnings in Sentry
* feat: added support for OTP logger * fix: added missing include. * only include otp logger header if it is needed
* chore: create exception reports lazily * more verbose
Quotes definition and use of the maybe/2 type, also exports the type from s2_maybe because it was already used as if exported from there.
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
2 times, most recently
from
July 15, 2024 12:12
ebda949
to
de77ba6
Compare
Ci on github no longer worked.
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
from
July 15, 2024 12:20
411fde8
to
0af3e44
Compare
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
from
July 15, 2024 12:26
9888563
to
961eb41
Compare
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
from
July 15, 2024 12:38
5429dd5
to
3408672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OTP 27 maybe will become a keyword so to support using stdlib2 in OTP27 we need to quote usages of maybe as an atom.