Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nimbora tvl calculation #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: nimbora tvl calculation #1

wants to merge 4 commits into from

Conversation

ioanSL
Copy link

@ioanSL ioanSL commented Apr 1, 2024

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):

@ioanSL ioanSL added the enhancement New feature or request label Apr 1, 2024
@ioanSL ioanSL requested a review from shardAstronaut April 1, 2024 12:23
@ioanSL ioanSL self-assigned this Apr 1, 2024
Copy link

@shardAstronaut shardAstronaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ioanSL
Copy link
Author

ioanSL commented Apr 3, 2024

Make sure we are good with those requirments https://github.com/0xSpaceShard/DefiLlama-Adapters/blob/main/README.md#defillama-adapters

It should be fine since the Debt amount is being fetched from the smart contracts.

@shardAstronaut
Copy link

Make sure we are good with those requirments https://github.com/0xSpaceShard/DefiLlama-Adapters/blob/main/README.md#defillama-adapters

It should be fine since the Debt amount is being fetched from the smart contracts.

Please ready carfully the requirements. They no more accept PR that fetch TVL from private APIs and we should not update the package-lock.json file.

@ioanSL
Copy link
Author

ioanSL commented Apr 4, 2024

Make sure we are good with those requirments https://github.com/0xSpaceShard/DefiLlama-Adapters/blob/main/README.md#defillama-adapters

It should be fine since the Debt amount is being fetched from the smart contracts.

Please ready carfully the requirements. They no more accept PR that fetch TVL from private APIs and we should not update the package-lock.json file.

We don't fetch the TVL from private API, only the borrow rate. So we can later calculate the collateral. We fetch the data from the L2 smart contracts.
Regarding the package-lock.json, it is true that they don't accept changes there, but only pkgs from specific projects, like for example they wouldn't accept nimbora-sdk pkg, but in this case I added math.js pkg which is generic.

@ioanSL ioanSL requested a review from shardAstronaut April 10, 2024 08:57
0xSacha pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants