refactor: remove usage of unstable generic_const_exprs in starky
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR mostly lifts 0xPolygonZero#1246 down into the lib level into the starky crate, getting rid of the unstable `generic_const_exprs` feature from the crate entirely. This should work towards the 0xPolygonZero#417 as well. This would probably warrant a minor version bump in the starky crate to 0.2.0, since this would be an API change for anyone relying on starky.
Nashtare
reviewed
Oct 22, 2023
Nashtare
approved these changes
Oct 23, 2023
starky/src/evaluation_frame.rs
Outdated
Comment on lines
18
to
19
| fn get_public_inputs(&self) -> &[U]; | ||
| /// Outputs a new evaluation frame from the provided local and next values. |
There was a problem hiding this comment.
Suggested change
| fn get_public_inputs(&self) -> &[U]; | |
| /// Outputs a new evaluation frame from the provided local and next values. | |
| fn get_public_inputs(&self) -> &[U]; | |
| /// Outputs a new evaluation frame from the provided local and next values. |
minor nit, but I'd add a separation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly lifts #1246 down into the lib level into the starky crate, getting rid of the unstable
generic_const_exprsfeature from the crate entirely. This should work towards the #417 as well.This would probably warrant a minor version bump in the starky crate to 0.2.0, since this would be an API change for anyone relying on starky.