Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bad variant of InitCollision #53

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Nashtare
Copy link
Contributor

There were 2 tests for which proving was failing because of an initial impossible configuration (empty account with non-empty storage).

  • FailedCreateRevertsDeletion_d0g0v0_Shanghai was implicitely removed when switching to parsing tests directly through the block RLP encodings as it contained some additional issues
  • InitCollision_d2g0v0_Shanghai remained to be removed

Given that there is only 1 such badly formed test that is passing the RLP decoding sanity checks, I just hardcoded the variant name when filtering, similarly to how ValueOverflow is filtered directly a few lines above.

@Nashtare Nashtare requested a review from BGluth January 24, 2024 20:14
@Nashtare Nashtare self-assigned this Jan 24, 2024
@Nashtare Nashtare merged commit 2b42419 into 0xPolygonZero:main Jan 25, 2024
2 checks passed
@Nashtare Nashtare deleted the ignore-malformed-test branch January 25, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants