Implement dummy IR padding for blocks with < 2 txns
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The deps were very out of date and we need them to be up to date to do padding.
- Now works on block heights <= 256. - Now pads blocks when there is < 2 txns.
- This is intended to be a short term solution. In the long term, this should probably be moved to a more robust config.
Nashtare
approved these changes
Apr 4, 2024
Nashtare
reviewed
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we realized that this tool will fail on blocks with less than
2txns due to aggregation being unable to happen in this case. This PR ports a lot of logic written specifically for this fromtrace_decoderand rpc logic fromzero-bin.This is ready for review, but I want to hold off on merging this back in until
v0.3.0ofzk_evmlands since currently we require a newer version of thezk_evmdeps than what's currently published oncrates.io.Resolves #14.
Other notes:
3lines per log message).minerfield from a call tocliqueinstead of what is contained in the response frometh_getBlockByNumber. Ideally, if we add more to this tool down the road, we probably want to move this to a config or similar.zero-bin.zero-binhas a lot of the rpc calls that we needed for this PR already done, and the logic it replaced is more bullet-proof against some edge cases (eg. blocks with a height <255would fail due to attempting to get the previous256block hashes).rpccall (previously was hard-coded).