Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode timelock tx in upgrade-banana #345

Merged
merged 1 commit into from
Oct 15, 2024
Merged

decode timelock tx in upgrade-banana #345

merged 1 commit into from
Oct 15, 2024

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • fixes missing deployer when deploying PolygonRollupManager
  • adds full decoded data (timelock data & payloads) to output json upgrade

@cla-bot cla-bot bot added the cla-signed label Oct 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ignasirv
ignasirv approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@invocamanman invocamanman merged commit 12bdfc7 into develop Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invocamanman invocamanman invocamanman approved these changes

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @invocamanman