Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit remediations #341

Merged
merged 1 commit into from
Oct 7, 2024
Merged

audit remediations #341

merged 1 commit into from
Oct 7, 2024

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • It contains the following audit remediation from sigmaPrime audit
    • RollupDataReturnV2 to be an address instead of IPolygonRollupBase
    • remove comparisons to true on PolygonRollupManager.sol
    • set getInputPessimsiticBytes in PolygonRollupManager.sol as external
    • correct typos & natspec

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@krlosMata krlosMata mentioned this pull request Oct 6, 2024
Merged
@invocamanman invocamanman merged commit d5de496 into feature/ongoingPP Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invocamanman invocamanman invocamanman approved these changes

@ignasirv ignasirv Awaiting requested review from ignasirv ignasirv is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlosMata @invocamanman