Add tests to docker build #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ignasirv
commented
Sep 25, 2024
•
ignasirv
commented
- Added test to docker build network to check build correctness
- New gha only to develop to test docker build gha without pushing the image
ignasirv
force-pushed
the
feature/fix-docker
branch
5 times, most recently
from
3d3739f
to
b9967a9
Compare
ignasirv
force-pushed
the
feature/fix-docker
branch
from
b9967a9
to
bf45a82
Compare
krlosMata
requested changes
Sep 25, 2024
krlosMata
requested changes
Sep 26, 2024
- Move docker tests logic to a separate script - Add initializer checks at docker tests - Refactor yml gha
ignasirv
force-pushed
the
feature/fix-docker
branch
from
ef34849
to
727c10b
Compare
ignasirv
force-pushed
the
feature/fix-docker
branch
from
3908211
to
1987a3b
Compare
krlosMata
requested changes
Sep 30, 2024
invocamanman
reviewed
Oct 1, 2024
| with: | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: true | ||
| tags: hermeznetwork/geth-zkevm-contracts:1.5-integration |
There was a problem hiding this comment.
jsut double checking the tag, is this correct?¿
There was a problem hiding this comment.
There was a problem hiding this comment.
No one is using the image created by the gha. Therefore, we can delete this entire gha
|
invocamanman
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.