Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contracts tests #300

Merged
merged 18 commits into from
Aug 5, 2024

Conversation

laisolizq
Copy link
Contributor

@laisolizq laisolizq commented Jul 24, 2024

This PR does the following:

  • update all tests
  • add test with VerifierType.Pessimistic
  • separate geters for Struct RollupData
  • update gha to pass test in feature/ongoingPP

IMPORTANT: storage layout check has been disabled in order to update the upgrade contract. It must be enabled again

@laisolizq laisolizq requested a review from krlosMata July 24, 2024 15:46
@cla-bot cla-bot bot added the cla-signed label Jul 24, 2024
@laisolizq laisolizq marked this pull request as draft July 24, 2024 15:46
@laisolizq laisolizq marked this pull request as ready for review July 25, 2024 15:59
@laisolizq laisolizq force-pushed the feature/ongoingPP-update-tests branch from 8e63ede to 1e3537b Compare July 26, 2024 07:56
@krlosMata krlosMata requested a review from ignasirv as a code owner July 26, 2024 08:23
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata force-pushed the feature/ongoingPP-update-tests branch from 773bf07 to 8942b02 Compare August 2, 2024 15:18
@invocamanman invocamanman force-pushed the feature/ongoingPP-update-tests branch from 996b75e to 8f06eb7 Compare August 5, 2024 17:41
@invocamanman invocamanman merged commit 63556cf into feature/ongoingPP Aug 5, 2024
5 checks passed
Copy link

sonarcloud bot commented Aug 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants