Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blobOuter, aggregation & final #153

Merged
merged 1 commit into from
Mar 28, 2024
Merged

add blobOuter, aggregation & final #153

merged 1 commit into from
Mar 28, 2024

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • implement blobOuterProcessor
  • update calculateSnarkInput
  • add the following methods to zkEVMDB
    • aggregateBatches
    • buildBlobInner
    • aggregateBlobOuters
  • update tests

@cla-bot cla-bot bot added the cla-signed label Mar 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
8.3% Duplication on New Code

See analysis details on SonarCloud

ignasirv
ignasirv approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit db00fa2 into develop-feijoa Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlosMata @ignasirv