Fix data race in fsm (#982)

* Fix data race in several places accessing fsm and fix copy validators function.

* tidy linter.

* Fix tests after changes and user RLock.

consensus/polybft/consensus_runtime.go

@@ -392,7 +392,9 @@ func (c *consensusRuntime) FSM() error {
 		"endOfSprint", isEndOfSprint,
 	)
 
+	c.lock.Lock()
 	c.fsm = ff
+	c.lock.Unlock()
 
 	return nil
 }
@@ -997,6 +999,9 @@ func (c *consensusRuntime) IsValidBlock(proposal []byte) bool {
 }
 
 func (c *consensusRuntime) IsValidSender(msg *proto.Message) bool {
+	c.lock.RLock()
+	defer c.lock.RUnlock()
+
 	err := c.fsm.ValidateSender(msg)
 	if err != nil {
 		c.logger.Error("invalid sender", "error", err)
@@ -1008,6 +1013,9 @@ func (c *consensusRuntime) IsValidSender(msg *proto.Message) bool {
 }
 
 func (c *consensusRuntime) IsProposer(id []byte, height, round uint64) bool {
+	c.lock.RLock()
+	defer c.lock.RUnlock()
+
 	nextProposer, err := c.fsm.validators.CalcProposer(round)
 	if err != nil {
 		c.logger.Error("cannot calculate proposer", "error", err)
@@ -1117,6 +1125,8 @@ func (c *consensusRuntime) HasQuorum(
 	messages []*proto.Message,
 	msgType proto.MessageType,
 ) bool {
+	c.lock.RLock()
+	defer c.lock.RUnlock()
 	// extract the addresses of all the signers of the messages
 	ppIncluded := false
 	signers := make(map[types.Address]struct{}, len(messages))

consensus/polybft/validator_set.go

@@ -501,7 +501,7 @@ func (v *validatorSet) Copy() *validatorSet {
 func validatorListCopy(valList []*ValidatorAccount) []*ValidatorAccount {
 	valCopy := make([]*ValidatorAccount, len(valList))
 	for i, val := range valList {
-		valCopy[i] = NewValidator(val.Metadata, val.ProposerPriority)
+		valCopy[i] = NewValidator(val.Metadata.Copy(), val.ProposerPriority)
 	}
 
 	return valCopy

consensus/polybft/validator_set_test.go

@@ -408,8 +408,11 @@ func TestValidatorSetTotalVotingPowerErrorOnOverflow(t *testing.T) {
 func TestUpdatesForNewValidatorSet(t *testing.T) {
 	t.Parallel()
 
-	v1 := &ValidatorMetadata{Address: types.Address{0x1}, VotingPower: 100}
-	v2 := &ValidatorMetadata{Address: types.Address{0x2}, VotingPower: 100}
+	keys, err := bls.CreateRandomBlsKeys(2)
+	require.NoError(t, err)
+
+	v1 := &ValidatorMetadata{Address: types.Address{0x1}, BlsKey: keys[0].PublicKey(), VotingPower: 100}
+	v2 := &ValidatorMetadata{Address: types.Address{0x2}, BlsKey: keys[1].PublicKey(), VotingPower: 100}
 	accountSet := []*ValidatorMetadata{v1, v2}
 	valSet, err := NewValidatorSet(accountSet, hclog.NewNullLogger())
 	require.NoError(t, err)