Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rollup address and rollup manager address in monitor #433

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jhkimqd
Copy link
Contributor

@jhkimqd jhkimqd commented Nov 12, 2024

Description

This PR adds two additional metrics to the monitor UI, following #429 :

  • Rollup Address
  • Rollup Manager Address

The above addresses are retrieved by using the new zkEVM API calls. This will only work on CDK Erigon images which have that PR merged in.

Testing

Tested locally with Kurtosis CDK
image

@jhkimqd jhkimqd marked this pull request as draft November 12, 2024 15:19
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small nit

cmd/monitor/ui/ui.go Outdated Show resolved Hide resolved
@jhkimqd jhkimqd marked this pull request as ready for review November 13, 2024 00:58
@leovct leovct merged commit 0de663e into 0xPolygon:main Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants