Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint issue after merge #163

Merged
merged 13 commits into from
Nov 20, 2023
Merged

fix: lint issue after merge #163

merged 13 commits into from
Nov 20, 2023

Conversation

rebelArtists
Copy link
Contributor

@rebelArtists rebelArtists commented Nov 20, 2023

Description

fix various lint issues that arose after merge:
Error: /home/runner/work/polygon-cli/polygon-cli/cmd/fund/fund.go:81:5: declaration of "err" shadows declaration at line 58
Error: cmd/fund/fund.go:8:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)

  • follow-up work: we should force ci checks to rerun after pushing commits EVEN AFTER pr has been approved or this situation can arise..

Jira / Linear Tickets

n/a

Testing

passed all CI lint tests

@rebelArtists rebelArtists marked this pull request as ready for review November 20, 2023 17:45
@rebelArtists rebelArtists merged commit 2ae3960 into main Nov 20, 2023
6 checks passed
@rebelArtists rebelArtists deleted the dan/bulk_fund_wallets branch November 20, 2023 18:02
@leovct
Copy link
Member

leovct commented Nov 21, 2023

Description

fix various lint issues that arose after merge: Error: /home/runner/work/polygon-cli/polygon-cli/cmd/fund/fund.go:81:5: declaration of "err" shadows declaration at line 58 Error: cmd/fund/fund.go:8:2: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)

  • follow-up work: we should force ci checks to rerun after pushing commits EVEN AFTER pr has been approved or this situation can arise..

Jira / Linear Tickets

n/a

Testing

passed all CI lint tests

Just enforced a few things in this repo.
Screenshot 2023-11-21 at 11 54 42

Screenshot 2023-11-21 at 11 57 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants