DVT-1057 replace block data structure with LRU cache to fix memory leak #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbyz
changed the title
gatsbyz
changed the title
leovct
reviewed
Nov 14, 2023
cmd/monitor/monitor.go
Outdated
| } | ||
| return nil | ||
| } | ||
| const maxDataPoints = 1000 |
There was a problem hiding this comment.
I think we should put this value at the top of the file with a comment that explains exactly what it does. I can imagine myself checking the code in 3 months wondering what this is about :)
leovct
reviewed
Nov 14, 2023
| blms = append(blms, ethrpc.BatchElem{ | ||
| Method: "eth_getBlockByNumber", | ||
| Args: []interface{}{"0x" + i.Text(16), true}, | ||
| Result: r, | ||
| Error: err, | ||
| Error: nil, |
leovct
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
I didn't review all the code as there are many changes in monitor.go but I went trough the code quickly. I tested and it looks good to me.
Side note: last PR, polycli monitor was working fine for me and not crashing at all (which is weird) but not for others so maybe wait for another review. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added functions
isBlockInCache: Determines if a given block number is already available in the LRU cache to avoid unnecessary network requests.checkAndFetchMissingBlocks: Identifies blocks not present in the cache within a specified range and fetches them from the Ethereum network to fill the cache.removed
currIdx,selectedBlock,Max/MinBlockRetrievedto clean up logic variablesfix after PR was reverted. Add back LRU lock when being read/written to prevent race condition.