chore: remove verbosity hack for polycli monitor
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #154.
Two things:
The hack worked fine, but it was poorly implemented as @minhd-vu suggested. This PR removes the hack and implements the functionality in a clean manner using
cmd.Flags().Lookup("verbosity")inPersistentPreRun.On top of that, if you wanted to override the verbosity value in
polycli monitor, it didn't work because it was hardcoded tosilentin my previous PR - 🤦 don't know how I missed that.... This PR modifies the implementation and overrides the default verbosity value properly and only if the user has not specified the verbosity via the flag.Jira / Linear Tickets
x
Testing
Set up the test environment.
# terminal 1 $ make anvil# terminal 2 $ make fund $ go run main.go loadtest --mode t --verbosity 600 --requests 100000000 --rate-limit 300go run main.go monitor --interval 0.01s- no logs + no glitchgo run main.go monitor --interval 0.01s --verbosity 400- logs + glitchgo run main.go monitor --interval 0.01s --verbosity 400 &> log.txt- no logs + no glitch