Pebble DB Integration into DB Bench Tool #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praetoriansentry
requested review from
leovct,
minhd-vu,
gatsbyz and
anshalshukla
praetoriansentry
commented
Nov 9, 2023
Comment on lines
+529
to
+530
| // It's not entirely obvious WHY this is needed, but without it, there are issues with the way that | ||
| // pebble db manages it's iterators and internal state. Level db works fine though. |
leovct
reviewed
Nov 10, 2023
cmd/dbbench/dbbench.go
Outdated
| wo *opt.WriteOptions | ||
| handle *leveldb.DB | ||
| } | ||
| PebbleDBWrapper struct { |
There was a problem hiding this comment.
nit: I would move most of the logic related to:
- PebbleDB in
pebbledb.go. - LevelDB in
leveldb.go. KeyValueDBandRandomKeySeekerindb_interface.goor something like this.
There was a problem hiding this comment.
I can move the pebbledb and leveldb implementations. I think that the common interferface between the two makes sense in the main package with the command. RandomKeySeeker, I have no point of view, it's just a utility class that I needed for now I'll probably leave it where it is
leovct
reviewed
Nov 10, 2023
cmd/dbbench/usage.md
Outdated
| @@ -2,7 +2,7 @@ This command is meant to give us a sense of the system level | |||
| performance for leveldb: | |||
|
|
|||
| ```bash | |||
| go run main.go leveldbbench --degree-of-parallelism 2 | jq '.' > result.json | |||
| go run main.go dbbench --degree-of-parallelism 2 | jq '.' > result.json | |||
There was a problem hiding this comment.
nit: replace go run main.go with polycli
leovct
reviewed
Nov 10, 2023
| @@ -2,7 +2,7 @@ This command is meant to give us a sense of the system level | |||
| performance for leveldb: | |||
|
|
|||
| ```bash | |||
| go run main.go leveldbbench --degree-of-parallelism 2 | jq '.' > result.json | |||
| go run main.go dbbench --degree-of-parallelism 2 | jq '.' > result.json | |||
| ``` | |||
|
|
|||
| In many cases, we'll want to emulate the performance characteristics | |||
There was a problem hiding this comment.
unrelated to the PR, but curious to know how you get these values
praetoriansentry
deleted the
DVT-1086-include-pebble-db-in-leveldbbench-tool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Geth has support for pebble db and it seems like bor will soon. This PR adds a mode flag to polycli to support testing a pebble db storage engine in addition to leveldb.
Testing
Generally, it seems like pebble db is faster in all of the categories except for random reads.
It does seem like there might be a pretty big difference in final state size
