fix: refactor to use for range loop

0xPolygon · Apr 4, 2023 · 4424abb · 4424abb
1 parent f2774d7
commit 4424abb
Showing 1 changed file with 15 additions and 18 deletions.
diff --git a/cmd/loadtest/loadtest.go b/cmd/loadtest/loadtest.go
@@ -557,25 +557,22 @@ func updateRateLimit(rl *rate.Limiter, rpc *ethrpc.Client, steadyStateQueueSize
 	ticker := time.NewTicker(cycleDuration)
 	defer ticker.Stop()
 
-	for {
-		select {
-		case <-ticker.C:
-			txPoolSize, err := getTxPoolSize(rpc)
-			if err != nil {
-				log.Error().Err(err).Msg("Error getting txpool size")
-				return
-			}
+	for range ticker.C {
+		txPoolSize, err := getTxPoolSize(rpc)
+		if err != nil {
+			log.Error().Err(err).Msg("Error getting txpool size")
+			return
+		}
 
-			if txPoolSize < steadyStateQueueSize {
-				// additively increment requests per second if txpool less than queue steady state
-				newRateLimit := rate.Limit(float64(rl.Limit()) + float64(rateLimitIncrement))
-				rl.SetLimit(newRateLimit)
-				log.Trace().Interface("New Rate Limit (RPS)", rl.Limit()).Interface("Current Tx Pool Size", txPoolSize).Interface("Steady State Tx Pool Size", steadyStateQueueSize).Msg("Increased rate limit")
-			} else if txPoolSize > steadyStateQueueSize {
-				// halve rate limit requests per second if txpool greater than queue steady state
-				rl.SetLimit(rl.Limit() / 2)
-				log.Trace().Interface("New rate limit", rl.Limit()).Interface("Current Tx Pool Size", txPoolSize).Interface("Steady State Tx Pool Size", steadyStateQueueSize).Msg("Backed off rate limit")
-			}
+		if txPoolSize < steadyStateQueueSize {
+			// additively increment requests per second if txpool less than queue steady state
+			newRateLimit := rate.Limit(float64(rl.Limit()) + float64(rateLimitIncrement))
+			rl.SetLimit(newRateLimit)
+			log.Trace().Interface("New Rate Limit (RPS)", rl.Limit()).Interface("Current Tx Pool Size", txPoolSize).Interface("Steady State Tx Pool Size", steadyStateQueueSize).Msg("Increased rate limit")
+		} else if txPoolSize > steadyStateQueueSize {
+			// halve rate limit requests per second if txpool greater than queue steady state
+			rl.SetLimit(rl.Limit() / 2)
+			log.Trace().Interface("New rate limit", rl.Limit()).Interface("Current Tx Pool Size", txPoolSize).Interface("Steady State Tx Pool Size", steadyStateQueueSize).Msg("Backed off rate limit")
 		}
 	}
 }