Spy detector in Peer-observer

[i-am-yuvi]

Fixes #43

This creates a tool, Spy-Detector that:

• prints stats of every peer(inv, tx, getdata) at every 10 secs
• for connection being closed their stats are printed and removed from shared state

[0xB10C]

INV and GetData messages can contain e.g. blocks too and not only transactions. You currently use the msg type string from the Metadata, but it's better to match on the message payload. You can filter out block INV and GetData messages there.

[i-am-yuvi]

INV and GetData messages can contain e.g. blocks too and not only transactions. You currently use the msg type string from the Metadata, but it's better to match on the message payload. You can filter out block INV and GetData messages there.

Agree!!

[i-am-yuvi]

INV and GetData messages can contain e.g. blocks too and not only transactions. You currently use the msg type string from the Metadata, but it's better to match on the message payload. You can filter out block INV and GetData messages there.

So basically INVs can contain blocks too, my question is:

• spy nodes can relay block inv but not transaction inv?
• can INV messages contain both Block and Tx at the same time?

[0xB10C]

So basically INVs can contain blocks too, my question is:

See https://docs.rs/bitcoin/latest/bitcoin/p2p/message_blockdata/enum.Inventory.html

We want to handle Inventory::Transaction and Inventory::WTx (protobuf definitions here

peer-observer/protobuf/proto-types/primitive.proto

Lines 49 to 52 in 712a51c

	bytes transaction = 1;
	bytes block = 2;
	// MSG_WTX (0x00000005) as defined in BIP 339 (wtxid based tx-relay)
	bytes wtx = 3;

) for INVs. We might need to handle Inventory::WitnessTransaction (

peer-observer/protobuf/proto-types/primitive.proto

Line 54 in 712a51c

bytes witness_transaction = 4;

) too for GET_DATA.

See also https://github.com/bitcoin/bitcoin/blob/5abb9b1af49be9024f95fa2f777285c531785d85/src/protocol.h#L473-L490 and the comments there.

• spy nodes can relay block inv but not transaction inv?

I think we can ignore block invs for now. Here, we are only interested in TX / WTX invs.

• can INV messages contain both Block and Tx at the same time?

Yes, that's possible, but not too common. Best would be to iterate over an INV message and increment the counter for each transaction/witness_transaction in the INV message.

[i-am-yuvi]

So basically INVs can contain blocks too, my question is:

See https://docs.rs/bitcoin/latest/bitcoin/p2p/message_blockdata/enum.Inventory.html

We want to handle Inventory::Transaction and Inventory::WTx (protobuf definitions here

peer-observer/protobuf/proto-types/primitive.proto

Lines 49 to 52 in 712a51c

	bytes transaction = 1;
	bytes block = 2;
	// MSG_WTX (0x00000005) as defined in BIP 339 (wtxid based tx-relay)
	bytes wtx = 3;

) for INVs. We might need to handle Inventory::WitnessTransaction (

peer-observer/protobuf/proto-types/primitive.proto

Line 54 in 712a51c

bytes witness_transaction = 4;

) too for GET_DATA.
See also https://github.com/bitcoin/bitcoin/blob/5abb9b1af49be9024f95fa2f777285c531785d85/src/protocol.h#L473-L490 and the comments there.

• spy nodes can relay block inv but not transaction inv?

I think we can ignore block invs for now. Here, we are only interested in TX / WTX invs.

• can INV messages contain both Block and Tx at the same time?

Yes, that's possible, but not too common. Best would be to iterate over an INV message and increment the counter for each transaction/witness_transaction in the INV message.

great!! Thanks for sharing!

[i-am-yuvi]

I think we can define primitive for Getdata too! @0xB10C ?

[0xB10C]

We already have one!

[i-am-yuvi]

We already have one!

Okay got it!!

[0xB10C]

Hey, are you still working on this?

[i-am-yuvi]

Hey, are you still working on this?

Yes, I am working!!

[i-am-yuvi]

Need to resolve conflicts and squash commits!!
I will do that soon!

[i-am-yuvi]

Continued in #57 , I'm closing this for now!