Give 'Server' a custom setter since that's public, and simplify Effec…

…tiveServer setter since that's private anyway
0x0ade · Aug 25, 2024 · 711748e · 711748e
1 parent 41bae2a
commit 711748e
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/CelesteNet.Client/CelesteNetClientSettings.cs b/CelesteNet.Client/CelesteNetClientSettings.cs
@@ -102,12 +102,7 @@ public bool ConnectDefaultVisible {
         public string EffectiveServer {
             get => ServerOverride.IsNullOrEmpty() ? Server : ServerOverride;
             private set {
-                if (Server == value)
-                    return;
-
                 Server = value;
-
-                UpdateServerInDialogs();
             }
         }
 
@@ -117,7 +112,18 @@ private set {
         [SettingIgnore]
 #endif
         [SettingSubText("modoptions_celestenetclient_devonlyhint")]
-        public string Server { get; set; } = DefaultServer;
+        public string Server {
+            get => _Server;
+            set {
+                if (_Server == value)
+                    return;
+
+                _Server = value;
+
+                UpdateServerInDialogs();
+            }
+        }
+        private string _Server = DefaultServer;
 
         // Any non-empty string will override Server property temporarily. (setting not saved)
         // Currently only used for "connect locally" button (for Nucleus etc.)