Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel Awesome #288

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Add Laravel Awesome #288

merged 2 commits into from
Oct 27, 2022

Conversation

0exbot
Copy link

@0exbot 0exbot commented Oct 27, 2022

Pull request from @theeMahmud.

[ boilerplate snipped ]

@0exbot
Copy link
Author

0exbot commented Oct 27, 2022

@-sindresorhus on 2022-05-27 03:29 says: Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@0exbot
Copy link
Author

0exbot commented Oct 27, 2022

@-atkirtland on 2022-06-01 04:32 says: Hi @-theeMahmud, here are a few of the things you need to fix.

  • awesome-lint returns many errors that you need to fix.
  • The name of your repo should be awesome-laravel.
  • You need to edit the pull request template by filling in blanks and adding an answer.
  • There is something you need to do after submitting your pull request; make sure to read the pull request template closely.
  • You need to have periods after each item description.
  • The table of contents should just be called "Contents".

@0exbot
Copy link
Author

0exbot commented Oct 27, 2022

@-prokopsimek on 2022-06-21 18:57 says: @-theeMahmud Please, complete the PR description and add 1) link to your repository, 2) explain what this list is about and why it should be included here.

@akvadrako akvadrako merged commit 55011f6 into main Oct 27, 2022
@akvadrako akvadrako deleted the pull/2270 branch October 27, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants