Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share file and remove duplicate test #1130

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fix share file and remove duplicate test #1130

merged 4 commits into from
Nov 21, 2024

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Nov 18, 2024 •
edited
Loading

@Hitenjain14 Hitenjain14 marked this pull request as draft November 18, 2024 08:28
This was referenced Nov 18, 2024
Merged
Merged
@Hitenjain14 Hitenjain14 marked this pull request as ready for review November 18, 2024 08:50
dabasov
dabasov approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 79ceb83 into master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@Jayashsatolia403 Jayashsatolia403 Awaiting requested review from Jayashsatolia403 Jayashsatolia403 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hitenjain14 @dabasov