Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packager logger for filtering logs #631

Closed
wants to merge 1 commit into from

Conversation

PratikDhanave
Copy link

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@PratikDhanave PratikDhanave marked this pull request as ready for review April 9, 2022 17:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #631 (3a2d749) into staging (d2c3392) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #631      +/-   ##
===========================================
+ Coverage    20.60%   20.67%   +0.06%     
===========================================
  Files           64       64              
  Lines         7327     7327              
===========================================
+ Hits          1510     1515       +5     
+ Misses        5590     5585       -5     
  Partials       227      227              
Flag Coverage Δ
Unit-Tests 20.67% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/core/lock/lock.go 100.00% <0.00%> (+13.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c3392...3a2d749. Read the comment docs.

@cnlangzi
Copy link
Contributor

@PratikDhanave please get tests passed first.

@lpoli
Copy link
Contributor

lpoli commented Apr 24, 2022

@PratikDhanave
Firstly, The logger that you wrote is not necessary. There is already core/logging which has all the necessary logging levels.
Secondly, You have not done anything that was raised in issue #290. What was required was to log critical errors, any thing that would be required while debugging, etc.

@peterlimg
Copy link
Member

@PratikDhanave please check the core/logging as @lpoli mentioned. @cnlangzi @lpoli please guide @PratikDhanave what need to do.

@PratikDhanave
Copy link
Author

@peterlimg @lpoli @cnlangzi I will update the pull request to log critical errors.

@lpoli lpoli self-assigned this May 4, 2022
@cnlangzi cnlangzi closed this May 30, 2022
@cnlangzi cnlangzi deleted the feature/logging-blobber-endpoints branch May 30, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants