Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug blobber replace #1480

Closed
wants to merge 2 commits into from
Closed

Conversation

Jayashsatolia403
Copy link
Collaborator

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (sprint-1.18@1a881b8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../0chain.net/blobbercore/handler/storage_handler.go 33.33% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##             sprint-1.18    #1480   +/-   ##
==============================================
  Coverage               ?   13.77%           
==============================================
  Files                  ?      180           
  Lines                  ?    21858           
  Branches               ?        0           
==============================================
  Hits                   ?     3010           
  Misses                 ?    18467           
  Partials               ?      381           
Flag Coverage Δ
Unit-Tests 13.77% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants