Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 1.12 #1383

Merged
merged 10 commits into from
Feb 8, 2024
Merged

Sprint 1.12 #1383

merged 10 commits into from
Feb 8, 2024

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Feb 6, 2024

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

Hitenjain14 and others added 8 commits January 4, 2024 18:17
* check prev root and add constraint (#1356)

* Hotfix update allocation worker

* Fix lint

* Fix

* Fixed updateAllocationInDB check as well

* check prev root and add constraint

* check if alloc is updated

* rmv check

---------

Co-authored-by: Jayash Satolia <[email protected]>

* add index for connection id (#1358)

* get round on start

* fix hook

---------

Co-authored-by: Jayash Satolia <[email protected]>
* check prev root and add constraint (#1356)

* Hotfix update allocation worker

* Fix lint

* Fix

* Fixed updateAllocationInDB check as well

* check prev root and add constraint

* check if alloc is updated

* rmv check

---------

Co-authored-by: Jayash Satolia <[email protected]>

* add index for connection id (#1358)

* Fix chall cancel commit (#1359)

* fix challenge cancel commit

* change conn lifetime

* Fixed updateAllocationInDB check as well (#1357)

* fix alloc lock for commit (#1363)

* Fix get round (#1361)

* check prev root and add constraint (#1356)

* Hotfix update allocation worker

* Fix lint

* Fix

* Fixed updateAllocationInDB check as well

* check prev root and add constraint

* check if alloc is updated

* rmv check

---------

Co-authored-by: Jayash Satolia <[email protected]>

* add index for connection id (#1358)

* get round on start

* fix hook

---------

Co-authored-by: Jayash Satolia <[email protected]>

* fix alloc lock for commit

* cleanup

---------

Co-authored-by: Jayash Satolia <[email protected]>

* fix max objects in dir

* fix ut

* fix commit lock (#1365)

---------

Co-authored-by: Jayash Satolia <[email protected]>
Co-authored-by: Jayash Satolia <[email protected]>
* fix list pagination

* fix offset

* fix dirListField

* select all fileds in getChildren

* cleanup
* add daily limit for commit

* update to golang 1.21

* update go version to 1.21

* update lru

* replace data by flag

* fixing docker build (#1376)

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

* fixing docker build

---------

Co-authored-by: Manohar Reddy <[email protected]>
Co-authored-by: shahnawaz-creator <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (cf1641c) 23.57% compared to head (3402040) 23.50%.
Report is 2 commits behind head on staging.

Files Patch % Lines
.../0chain.net/blobbercore/handler/storage_handler.go 0.00% 24 Missing ⚠️
.../go/0chain.net/blobbercore/handler/client_quota.go 0.00% 23 Missing ⚠️
code/go/0chain.net/blobbercore/reference/ref.go 34.37% 21 Missing ⚠️
...chain.net/blobbercore/allocation/copyfilechange.go 0.00% 3 Missing and 1 partial ⚠️
....net/blobbercore/allocation/file_changer_upload.go 0.00% 4 Missing ⚠️
...chain.net/blobbercore/allocation/movefilechange.go 0.00% 3 Missing and 1 partial ⚠️
...o/0chain.net/blobbercore/handler/download_quota.go 0.00% 4 Missing ⚠️
...et/blobbercore/handler/object_operation_handler.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1383      +/-   ##
===========================================
- Coverage    23.57%   23.50%   -0.07%     
===========================================
  Files           87       87              
  Lines        10124    10196      +72     
===========================================
+ Hits          2387     2397      +10     
- Misses        7441     7502      +61     
- Partials       296      297       +1     
Flag Coverage Δ
Unit-Tests 23.50% <11.45%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabasov dabasov merged commit cce361c into staging Feb 8, 2024
5 of 9 checks passed
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber staging
authorizer
0box
0dns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants