Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validator diagnostics #1205

Merged
merged 6 commits into from
Aug 12, 2023
Merged

Conversation

Jayashsatolia403
Copy link
Collaborator

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Merging #1205 (7cfad4f) into sprint-july-4 (3a1a405) will decrease coverage by 0.17%.
The diff coverage is 4.10%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                @@
##           sprint-july-4    #1205      +/-   ##
=================================================
- Coverage          25.52%   25.35%   -0.17%     
=================================================
  Files                 81       82       +1     
  Lines               9136     9209      +73     
=================================================
+ Hits                2332     2335       +3     
- Misses              6514     6584      +70     
  Partials             290      290              
Flag Coverage Δ
Unit-Tests 25.35% <4.10%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ain.net/validatorcore/storage/challenge_handler.go 24.29% <0.00%> (-0.71%) ⬇️
...o/0chain.net/validatorcore/storage/handler_main.go 0.00% <0.00%> (ø)
.../0chain.net/validatorcore/storage/stats_handler.go 4.41% <4.41%> (ø)

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mutex to update stats

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 1637690 into sprint-july-4 Aug 12, 2023
4 of 5 checks passed
@dabasov dabasov deleted the feature/validator-diagnostics branch August 12, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create diagnostics pages for validators and authroizers
3 participants