Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/case 2 and case 4 #1196

Closed
wants to merge 50 commits into from
Closed

Add/case 2 and case 4 #1196

wants to merge 50 commits into from

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Aug 4, 2023

Changes

This PR is in draft state. It needs to add last two cases of 0chain/0chain#2559.
Currently case 3 is add but is yet to be tested. Case 4 is similar to case-3.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Jayashsatolia403 and others added 30 commits May 31, 2023 12:28
…_challenge_id' into feature/get_challenge_timings_by_challenge_id
* get path from changes

* pass rootRef in apply changes

* add logs

* fix deletechange

* fix multi op and copy

* fix delete root dir

* fix delete root change

* fix lint issue

* cleanup and stats change

* rename func to processMove

* calculate object tree in ref path

* rmv return from deleteChange

* revert changes

* move to filestore changes

* check prevRoot

* add logs and condition

* check filestore

* requested changes

* validate nil proof

* add move and copy dir tests

* add logs

* use path to add child

* fix error log

* fix add child

* add proof log

* add more logs

* change read log

* log objectPath

* add commit logs

* commit thumbnail first

* add missing param

* add missing param

* add path in the thumbnail hash

* add allocID and validation root index

* use write

* add condn in count query

* rmv thumbnail_filename

* log wm

* cleanup

* add rollback wm check

* allow empty allocation root

* fix tests

* check path in upload

* fix check

* empty commit

---------

Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: Yury <[email protected]>
* dependencies update

* dependencies update
* rmv fileID from hash calc

* Trigger Build

* adding false commit to restart systemtests

* add path in fileMetaHash

* empty commit

---------

Co-authored-by: Yury <[email protected]>
Co-authored-by: shahnawaz-creator <[email protected]>
Co-authored-by: boddumanohar <[email protected]>
Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: boddumanohar <[email protected]>
* update challenge timing submission

* fix createdAt in challenge timing table

---------

Co-authored-by: Yury <[email protected]>
Jayashsatolia403 and others added 20 commits July 29, 2023 17:31
* Fix

* Fix

* Fix

* Debug

* Debug

* Fix lint

* Fix

* Fix

* False commit

* Fix

* Debug

* False commit

* Fix

* Fix

* Fix

* Fix timestamp error

* Added caching in GetOrCreate too

* Fix

* Fix typecast

* Add path in thumbnail hash (#1098)

* get path from changes

* pass rootRef in apply changes

* add logs

* fix deletechange

* fix multi op and copy

* fix delete root dir

* fix delete root change

* fix lint issue

* cleanup and stats change

* rename func to processMove

* calculate object tree in ref path

* rmv return from deleteChange

* revert changes

* move to filestore changes

* check prevRoot

* add logs and condition

* check filestore

* requested changes

* validate nil proof

* add move and copy dir tests

* add logs

* use path to add child

* fix error log

* fix add child

* add proof log

* add more logs

* change read log

* log objectPath

* add commit logs

* commit thumbnail first

* add missing param

* add missing param

* add path in the thumbnail hash

* add allocID and validation root index

* use write

* add condn in count query

* rmv thumbnail_filename

* log wm

* cleanup

* add rollback wm check

* allow empty allocation root

* fix tests

* check path in upload

* fix check

* empty commit

---------

Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: Yury <[email protected]>

* Dep/update (#1153)

* dependencies update

* dependencies update

* Remove fileID from fileMetaHash (#1114)

* rmv fileID from hash calc

* Trigger Build

* adding false commit to restart systemtests

* add path in fileMetaHash

* empty commit

---------

Co-authored-by: Yury <[email protected]>
Co-authored-by: shahnawaz-creator <[email protected]>
Co-authored-by: boddumanohar <[email protected]>
Co-authored-by: Kishan Dhakan <[email protected]>

* Fixed lints

* Added ceil

* optimize image (#1148)

Co-authored-by: boddumanohar <[email protected]>

* Fix

* once for logger init

* Update challenge timing submission (#1140)

* update challenge timing submission

* fix createdAt in challenge timing table

---------

Co-authored-by: Yury <[email protected]>

* Fix blobber size (#1163)

* cleaning up caching code

* Do not redeem readmarkers for free reads (#1166)

* do not redeem readmarkers for free reads

* fix unit tests, remove readmarker handling from download method

* once for logger init (#1156)

* once for logger init

* init logging the same way we do in 0chain

* init logging the same way we do in 0chain

* Hotfix/map concurrent write (#1158)

* once for logger init

* wider locking window

* Hotfix/remove custom nonce (#1141)

* removed custom nonce managing logic

* fixed logging

* updated gosdk

* uncommented previous nonce logic

* uncommented previous nonce logic

* uncommented previous nonce logic

* uncommented previous nonce logic

* Use single file to avoid maintaining multiple version of same file (#1160)

* Use single file to avoid maintaining multiple version of same file

* Fix config path

* Remove variable

* Update path variable for blobber service

---------

Co-authored-by: Yury <[email protected]>

* fix consume quota lock (#1173)

* add sprint* branches in tests.yml

* fixed merge problem

* fixed merge problem

* add logs in wm lock

* fixed broken unit test

* fix type assertion

* fix nil pointer dereference

* fix get alloc by id

---------

Co-authored-by: Hitenjain14 <[email protected]>
Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: Yury <[email protected]>
Co-authored-by: shahnawaz-creator <[email protected]>
Co-authored-by: boddumanohar <[email protected]>
Co-authored-by: Manali-Jain-squareops <[email protected]>
Co-authored-by: stewartie4 <[email protected]>
Co-authored-by: Dinmukhammed <[email protected]>
Co-authored-by: Laxmi Prasad Oli <[email protected]>
Co-authored-by: Hitenjain14 <[email protected]>
Co-authored-by: din-mukhammed <[email protected]>
Save allocation using cache method
…challenge_timings_by_challenge_id

# Conflicts:
#	code/go/0chain.net/blobbercore/readmarker/readmarker.go
#	docker.local/.dockerignore
#	go.mod
#	go.sum
…_challenge_id

Added challenge-timings-by-challengeId endpoint
@lpoli lpoli mentioned this pull request Aug 4, 2023
3 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #1196 (73ded20) into staging (37b1a6c) will decrease coverage by 0.22%.
Report is 1 commits behind head on staging.
The diff coverage is 4.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           staging    #1196      +/-   ##
===========================================
- Coverage    25.69%   25.48%   -0.22%     
===========================================
  Files           80       83       +3     
  Lines         9047     9175     +128     
===========================================
+ Hits          2325     2338      +13     
- Misses        6431     6546     +115     
  Partials       291      291              
Flag Coverage Δ
Unit-Tests 25.48% <4.59%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
code/go/0chain.net/blobbercore/allocation/dao.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (ø)
...e/go/0chain.net/blobbercore/allocation/protocol.go 0.00% <0.00%> (ø)
...ain.net/blobbercore/allocation/renamefilechange.go 46.51% <ø> (ø)
...e/go/0chain.net/blobbercore/allocation/rollback.go 0.00% <0.00%> (ø)
...de/go/0chain.net/blobbercore/allocation/workers.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/allocation/zcn.go 0.00% <0.00%> (ø)
...chain.net/blobbercore/handler/challenge_timings.go 0.00% <0.00%> (ø)
...0chain.net/blobbercore/handler/handler_playlist.go 25.75% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 18.70% <0.00%> (+0.01%) ⬆️
... and 14 more

... and 1 file with indirect coverage changes

@lpoli lpoli closed this Aug 4, 2023
@lpoli lpoli deleted the add/case-2-and-case-4 branch August 4, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants