Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/conductor tests for blobber and validator #2651

Merged
merged 60 commits into from
Sep 11, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Jul 27, 2023

Fixes

This PR resolves first two cases of issue 2559

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (sprint-1.11@1a63fd0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...hain.net/smartcontract/storagesc/challenge_main.go 40.00% 9 Missing ⚠️
code/go/0chain.net/miner/protocol_block.go 68.42% 5 Missing and 1 partial ⚠️
code/go/0chain.net/chaincore/chain/worker.go 0.00% 4 Missing ⚠️
...ode/go/0chain.net/chaincore/chain/post_finalize.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##             sprint-1.11    #2651   +/-   ##
==============================================
  Coverage               ?   28.50%           
==============================================
  Files                  ?      392           
  Lines                  ?    65744           
  Branches               ?        0           
==============================================
  Hits                   ?    18738           
  Misses                 ?    44762           
  Partials               ?     2244           
Flag Coverage Δ
Unit-Tests 28.50% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabasov dabasov changed the base branch from sprint-july-4 to sprint-1.10 August 21, 2023 09:51
@devyetii devyetii changed the base branch from sprint-1.10 to sprint-1.11 September 7, 2023 06:28
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 0fb5e3b into sprint-1.11 Sep 11, 2023
6 checks passed
@dabasov dabasov deleted the add/conductor-tests-for-blobber-and-validator branch September 11, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants