Add reminder op for floats

[wader]

This is same as jq modulo (hoh) error message:

$ jq -n 'def f: -2, -1, 0, 2.1, 3, 4000000001; [f as $a | f as $b | try ($a % $b) catch .]'
[
  0,
  0,
  "number (-2) and number (0) cannot be divided (remainder) because the divisor is zero",
  0,
  -2,
  -2,
  -1,
  0,
  "number (-1) and number (0) cannot be divided (remainder) because the divisor is zero",
  -1,
  -1,
  -1,
  0,
  0,
  "number (0) and number (0) cannot be divided (remainder) because the divisor is zero",
  0,
  0,
  0,
  0,
  0,
  "number (2.1) and number (0) cannot be divided (remainder) because the divisor is zero",
  0,
  2,
  2,
  1,
  0,
  "number (3) and number (0) cannot be divided (remainder) because the divisor is zero",
  1,
  0,
  3,
  1,
  0,
  "number (4000000001) and number (0) cannot be divided (remainder) because the divisor is zero",
  1,
  2,
  0
]

[wader]

Seems CI failure is same as what main branch is failing on

[01mf02]

In accordance with what I wrote in #232 (comment), I think that the behaviour in this PR is not desirable, because it silently loses information about the decimal points. I'm sorry. I hope you understand.

[wader]

No worries :) and the reason why jaq does not do non-integer reminder is because jq lacks it? i wonder if jaq's README or documentation could benefit from some notes and gotchas about how to do integer reminder etc, ex using floor etc?

[01mf02]

Hmmm ... we could actually implement non-integer remainders quite easily, because we can already do l % r in Rust for floating-point numbers l and r, see: https://doc.rust-lang.org/std/primitive.f64.html#impl-Rem-for-f64
That means that when we calculate l % r and either l or r are float, then the other argument should be converted to a float as well and floating-point remainder should be calculated.
I think that if you would adapt your PR that way, I would accept it.

i wonder if jaq's README or documentation could benefit from some notes and gotchas about how to do integer reminder etc, ex using floor etc?

I thought that the "Numbers" section of the README did already contain this information. If you have a specific text in mind, I'm all for a little PR. :)

[wader]

Hmmm ... we could actually implement non-integer remainders quite easily, because we can already do l % r in Rust for floating-point numbers l and r, see: https://doc.rust-lang.org/std/primitive.f64.html#impl-Rem-for-f64 That means that when we calculate l % r and either l or r are float, then the other argument should be converted to a float as well and floating-point remainder should be calculated. I think that if you would adapt your PR that way, I would accept it.

Ah ok! yeap i can have a look at that

i wonder if jaq's README or documentation could benefit from some notes and gotchas about how to do integer reminder etc, ex using floor etc?

I thought that the "Numbers" section of the README did already contain this information. If you have a specific text in mind, I'm all for a little PR. :)

Oh great 👍 not sure how i didn't see that

[wader]

Switch float, but i'm not sure i really follow how reminder and floats work :) have to read more about it

$ cargo run -- -n -- '-2 / 2.1, -2 % 2.1'
-0.9523809523809523
-2.0

[wader]

Not sure i understand why this is needed, because the value is NaN?