Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] MVC class naming convention #45

Open
tai271828 opened this issue Dec 30, 2020 · 2 comments
Open

[Feature Request] MVC class naming convention #45

tai271828 opened this issue Dec 30, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tai271828
Copy link
Collaborator

Is your feature request related to a problem?

Currently it has the prefix style with C and a lower case timer, e.g. Ctimer. However in the --overall figure it shows CTimer in the title. The naming convention is not consistent.

Describe the solution you'd like

Use capital Time instead, e.g. CTimer, for all classes.

Additional context

The camel case naming style also implies capitals means individual words, so Ctimer means Concentrationtimer/Ctimer, and CTimer means Concentration Timer.

@tai271828 tai271828 added the enhancement New feature or request label Dec 30, 2020
@zztin
Copy link
Owner

zztin commented Jan 15, 2021

Good point.
Let's make Ctimer as a customized word.
For camel cases: CtimerXxxxXxxx
For documentation: Ctimer
For repository name and folder name where the convention is all lower case: ctimer
Will you take care of unifying the styling? @tai271828

@tai271828
Copy link
Collaborator Author

Sounds good. Will do!

@tai271828 tai271828 self-assigned this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants