Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I make a Pull Request of my fork? #1

Open
oliverpool opened this issue Jul 7, 2017 · 2 comments
Open

Should I make a Pull Request of my fork? #1

oliverpool opened this issue Jul 7, 2017 · 2 comments

Comments

@oliverpool
Copy link

Hi,

I need to control an aria2 daemon from go and I found your library.
I found it quite neat and I wanted to improve it (to improve my "go-writing" skills ^^).

I took the liberty of creating a fork and reorganizing it quite heavily : https://github.com/oliverpool/argo (I tried to make a nice godoc page, with a complete example : https://godoc.org/github.com/oliverpool/argo).

I you want, I can make a PR to merge it into your library (it will break all compatibility) or we can let them live separately (You can see diff : master...oliverpool:master).

I did not implement the system.multicall RPC method yet (because it is quite complicated). But maybe I could implement it using a special Caller which could gather them and send them all at the same time.

@oliverpool oliverpool changed the title Shall I make a Pull Request of my fork? Should I make a Pull Request of my fork? Jul 7, 2017
@zyxar
Copy link
Owner

zyxar commented Jul 11, 2017

Wow, that seems like a rewrite of the package. But since I don't have enough time to look into your changes carefully, (and the compatibility issue) I think it better to let them live separately. It serves well in several of my personal projects.

Anyway, thank you.

@zyxar
Copy link
Owner

zyxar commented Jul 11, 2017

BTW, it's not necessary to implement system.multicall since imo it's not that practical to call such method from Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants