Add sources to completions APIs and UI #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On note 2, we could maybe add an input parameter to the call, same as "stream" that is "include_context_sources" or something like that. |
lopagela
previously approved these changes
Nov 11, 2023
pabloogc
reviewed
Nov 11, 2023
| ) | ||
|
|
||
| @classmethod | ||
| def from_node(cls: type["Chunk"], node: NodeWithScore) -> "Chunk": |
There was a problem hiding this comment.
you couldn't use the Chunk type here? circular reference?
There was a problem hiding this comment.
The reason is that this class method is defined within Chunk class definition. So Chunk type is not ready.
pabloogc
reviewed
Nov 11, 2023
private_gpt/open_ai/openai_models.py
Outdated
| @@ -48,8 +52,11 @@ class OpenAICompletion(BaseModel): | |||
| choices: list[OpenAIChoice] | |||
|
|
|||
| @classmethod | |||
| def from_text( | |||
| cls, text: str | None, finish_reason: str | None = None | |||
| def from_text_and_sources( | |||
There was a problem hiding this comment.
tiny nit, but if you name the function from_text_and_sources I would expect the sources to be mandatory, and from_text to still be there but with the sources as an optional arg.
from_text(all_options_nullable), from_text_and_sources(options, non-null sources) -> call from_text
pabloogc
previously approved these changes
Nov 11, 2023
lopagela
approved these changes
Nov 11, 2023
simonbermudez
pushed a commit
to simonbermudez/saimon
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse
Chunkobject to append the sources used during completions to the completions response.Affects both chat/completions and plain /completions
It has been integrated in the API and UI (see attachments).
Note 1:
Chunks returned as sources will always have theirprevious_textsandnext_textsset to none, given those are intended to be only used in the /chunks API - therefore we could eventually separate both objects (Chunks used for source representation, and /chunks API response)Note 2: this information is also being added to the stream API, making the streaming chunks too big in my opinion, potentially affecting performance; should we remove sources from the streaming API?