Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse JSON files using llama_index JSONReader #1176

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

lopagela
Copy link
Contributor

@lopagela lopagela commented Nov 7, 2023

Patch the default list of llama_index to support JSON files. This injection of JSON documents should improve the comprehension in JSON files, as there is a parsing of JSON files.

It might avoid the docstore pollution that we've been seeing in reported issues lately

Patch the default list of llama_index to support JSON files.
This injection of JSON documents should improve the comprehension in
JSON files, as there is a parsing of JSON files.
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Just a couple comments.

private_gpt/server/ingest/ingest_service.py Outdated Show resolved Hide resolved
private_gpt/server/ingest/ingest_service.py Show resolved Hide resolved
@lopagela lopagela requested a review from imartinez November 7, 2023 14:18
@imartinez imartinez merged commit 23cd3fe into zylon-ai:main Nov 7, 2023
6 checks passed
@lopagela lopagela deleted the use-dedicated-json-reader branch November 7, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants