Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: listen for node info received event #3954

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: listen for node info received event #3954

merged 1 commit into from
Oct 17, 2024

Conversation

robertsLando
Copy link
Member

Ref #3936

@robertsLando
Copy link
Member Author

cc @AlCalzone Should I react to this someway?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11381668746

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 21.006%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/ZwaveClient.ts 0 12 0.0%
Totals Coverage Status
Change from base Build 11381547633: -0.01%
Covered Lines: 3925
Relevant Lines: 19866
💛 - Coveralls

@AlCalzone
Copy link
Member

No. It can be used as a hook for automations, no point in doing that in the UI.

@robertsLando
Copy link
Member Author

Ok, so I will just emit the event in case someone wants to react to it when using MQTT

@robertsLando robertsLando merged commit 8f873a2 into master Oct 17, 2024
9 checks passed
@robertsLando robertsLando deleted the nif-event branch October 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertsLando @coveralls @AlCalzone