fix(ui): scanning of small QR codes #3946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nimiq/qr-scanner uses the native BarcodeDetector if available in browsers (essentially only Chrome), otherwise defaults to a JS port of ZXing. That port seems to be suboptimal, since it really struggles with the small Z-Wave QR codes.
https://www.npmjs.com/package/barcode-detector is a polyfill based on the WASM version of ZXing, which works much, much better. I was able to scan a tiny, blurry, distorted QR code in a second, without having to select "small QR code", or aiming a lot.
We need to decide how to include the wasm module though, since we don't want to download it at runtime, see https://github.com/Sec-ant/barcode-detector?tab=readme-ov-file#setzxingmoduleoverrides