Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] [Windows] If chrome not found, use edge #134

Open
Merith-TK opened this issue Jan 8, 2021 · 5 comments
Open

[Suggestion] [Windows] If chrome not found, use edge #134

Merith-TK opened this issue Jan 8, 2021 · 5 comments

Comments

@Merith-TK
Copy link

Yeah I know it's not gonna be a popular suggestion, but it is one nonetheless because I use brave browser so I had to clone the repo and add a line in locate.go to point to brave browser

os.Getenv("ProgramFiles(x86)") + "/BraveSoftware/Brave-Browser/Application/brave.exe",

@zserge
Copy link
Owner

zserge commented May 15, 2021

A PR for this would be welcome, the more Chrome-compatible browsers we support - the better.

@patarapolw
Copy link

patarapolw commented May 21, 2021

Suggestion, actually. Let developer choose which browsers to support. Probably you make an API to put in supported browsers - chrome.go, edge.go, brave.go; and if possible, firefox.go.

Another suggestion. github-workflow matrix separated for each browser / each OS's

Edit: See https://github.com/patarapolw/webviewless/blob/main/brave.go

Brave doesn't have same api as chrome (and they don't admit it). Also, there is no brave --help.

@marcosnils
Copy link

export LORCACHROME=`which brave-browser` seems to work just fine.

@Merith-TK
Copy link
Author

Well also consider edge, it has the same setup as chrome to my knowledge and appears to work just fine with pretty much any chrome based tool I have used. Since its more integrated and optimized for the windows operating system.

Edge is good* For Windows.

@FrankFang
Copy link

#137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants