Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use dialog? #94

Open
tcoopman opened this issue Sep 25, 2018 · 3 comments
Open

How to use dialog? #94

tcoopman opened this issue Sep 25, 2018 · 3 comments

Comments

@tcoopman
Copy link

I don't find any way to use the dialog? reading https://pptr.dev/#?product=Puppeteer&version=v1.8.0&show=api-class-dialog it seems that I should use Page.on, but that's not implemented?

@zploskey
Copy link
Owner

I have started adding events in #93. You can try out that branch if you would like. It still needs some testing and polish and the types may change a bit still. Custom events will need to be added to the event type.

@zploskey
Copy link
Owner

The easiest alternative right now is to make a really simple binding to Page.on that takes a string (and we may provide that as an escape hatch in the API as well). We would eventually like to have a complete well-typed solution.

@tcoopman
Copy link
Author

I'm using bs.raw at the moment to do everything I need with the dialog. That's the great part of bucklescript, easy to drop back to js. So for now I'm good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants