Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of keyring url is incorrect #3926

Open
pj892031 opened this issue Jul 26, 2024 · 1 comment
Open

Validation of keyring url is incorrect #3926

pj892031 opened this issue Jul 26, 2024 · 1 comment
Assignees
Labels
config enhancement New feature or request

Comments

@pj892031
Copy link
Contributor

"pattern": "^safkeyring:\/\/.*"

The validation assumes that the protocol is always safkeyring. It is not true since Java 11, it should allow at least safkeyringjce. Anyway, there are also other types, so the proper validation should be like ^safkeyring[a-z]*:\/\/.

There are workarounds:

  • disable validation
  • use systems environment such as SERVER_SSL_KEYRING to provide the correct value
  • change start.sh script
@1000TurquoisePogs
Copy link
Member

1000TurquoisePogs commented Jul 31, 2024

I confirm that zss and app-server both tolerate safkeyring.*
zss checks for "safkeyring.*://"
app-server checks for "safkeyring.*"
So, a schema change here and use of java 11 names wont break them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants