Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate type hints and fix any incorrect ones #321

Open
t1m0thyj opened this issue Aug 6, 2024 · 1 comment
Open

Validate type hints and fix any incorrect ones #321

t1m0thyj opened this issue Aug 6, 2024 · 1 comment
Labels
bug Something isn't working priority-medium severity-low

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Aug 6, 2024

In #312 we added type annotations, but currently they are not being validated.

  • Investigate running mypy in CI to validate existing type annotations
  • Consider adding MyPy Type Checker to list of recommended extensions: .vscode/extensions.json
  • Fix any incorrect type annotations found (e.g. return type of RequestHandler.perform_request is not dict)
@t1m0thyj t1m0thyj added the bug Something isn't working label Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority-medium severity-low
Projects
Zowe CLI Squad
Status: Medium Priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t1m0thyj @JTonda