Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups with unicode characters in the name do not load #552

Open
tnajdek opened this issue Jul 9, 2024 · 1 comment
Open

Groups with unicode characters in the name do not load #552

tnajdek opened this issue Jul 9, 2024 · 1 comment
Assignees

Comments

@tnajdek
Copy link
Member

tnajdek commented Jul 9, 2024

The culprit is the slugify function which attempts to mirror names that server provides. This needs to allow unicode characters.

https://forums.zotero.org/discussion/comment/467555/#Comment_467555

@tnajdek tnajdek added the bug label Jul 9, 2024
@tnajdek tnajdek self-assigned this Jul 9, 2024
tnajdek added a commit to tnajdek/web-library that referenced this issue Jul 9, 2024
@tnajdek
Copy link
Member Author

tnajdek commented Jul 10, 2024

So I've made a tweak to allow all letters from all languages for now which should resolve the reported issue. In truth, web library does not use this slug for anything so it could be anything, however it cannot be an empty string because routing expects there to be a group name in the URL.

This unfortunately does not resolve all problems. One can have a private group named "☃︎" which still produces empty slug, so we either need to disallow names like this or rethink the URL scheme.

@tnajdek tnajdek reopened this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant