Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise item details pane #503

Open
tnajdek opened this issue Feb 16, 2023 · 0 comments
Open

Optimise item details pane #503

tnajdek opened this issue Feb 16, 2023 · 0 comments
Assignees
@tnajdek
Labels
performance refactoring

Comments

@tnajdek
Copy link
Member

tnajdek commented Feb 16, 2023 •
edited
Loading

Currently each tab pane is keyed off item.key so that it renders fresh instance for every item. Re-using existing is not possible as some nested components (e.g. <Creators />) depends on this and end up rendering old values.
@tnajdek tnajdek self-assigned this Feb 16, 2023
tnajdek added a commit that referenced this issue Feb 16, 2023
@tnajdek
Fix regression: wrong creators displayed #503
1b98e41 
Reverted optimisation as it needs more work in nested components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnajdek tnajdek

Labels
performance refactoring
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tnajdek