Adding Dalloz, Dalloz Bibliothèque, Lextenso, Vie Publique and Jus Politicum translators. #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carnetdethese
changed the title
carnetdethese
changed the title
AbeJellinek
requested changes
Apr 22, 2024
Dalloz Bibliotheque.js
Outdated
| "translatorID": "2ea86ad9-71ca-410c-9126-9d7d98722acf", | ||
| "label": "Dalloz Bibliothèque", | ||
| "creator": "Alexandre Mimms", | ||
| "target": "https?://(?:www[.-])?bibliotheque[.-]lefebvre[.-]dalloz(?:[.-]fr)?", |
There was a problem hiding this comment.
I'm guessing the [.-]s are to support proxies? We don't do that here. Add your proxy to the Zotero Connector and the translator will get correct URLs automatically.
Suggested change
| "target": "https?://(?:www[.-])?bibliotheque[.-]lefebvre[.-]dalloz(?:[.-]fr)?", | |
| "target": "https?://(www\\.)?bibliotheque\\.lefebvre\\.dalloz\\.fr", |
Co-authored-by: Abe Jellinek <[email protected]>
Co-authored-by: Abe Jellinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding translators for the Legal databases Dalloz, Dalloz Bibliothèque, Lextenso, Jus Politicum and Vie Publique.