Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config tool: does not delete test_suite in setup.py #30

Closed
jugmac00 opened this issue May 15, 2020 · 4 comments
Closed

config tool: does not delete test_suite in setup.py #30

jugmac00 opened this issue May 15, 2020 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@jugmac00
Copy link
Member

As I understand test_suite='zc.zdaemonrecipe.tests.test_suite', was only necessary for calling the tests via the deprecated python setup.py tests call.

The config tool uses zope.testrunner, which does not need this entry point, right?

@mgedmin
Copy link
Member

mgedmin commented May 15, 2020

That's correct.

@mgedmin
Copy link
Member

mgedmin commented May 15, 2020

Two exceptions exist that I know of:

  • zope.testrunner cannot really use itself, so it uses python setup.py test.
  • zope.interface is a dependency of zope.testrunner, so to avoid dependency loops it also avoids relying on zope.testrunner and uses python setup.py test.

setup.py test is deprecated in setuptools, but I don't think there are plans to actually remove it any time soon.

All other packages should not be using or supporting setup.py test. (It's possible that other exceptions with good reasons might exist, and I just don't know about them.)

@jamadden
Copy link
Member

zope.interface uses the standard library python -m unittest discover command. It dropped 'setup.py test' some time ago (although by default I think that does basically the same thing).

@icemac
Copy link
Member

icemac commented Oct 2, 2024

Duplicates #260.

@icemac icemac closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
@icemac icemac added the duplicate This issue or pull request already exists label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants