You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just for context: The only reason isort is still pinned here is because isort 5 requires a ton of code changes. This is not complicated, just a lot of work and a lot of checking and a lot of eyeballing code changes. Those code changes are all cosmetic, so it has not been a priority. Pinning isort let's Travis stay green until someone takes the time to take this on. If you want to do it that's great.
How to run isort is an entirely separate issue. Just like with flake8 in #891 I am strongly against moving it out of tox.ini.
* Update `isort` to version 5.
This fixes#892
* Restore flags for `isort`
modified: tox.ini
* Move first party imports into `known_zope`
* Use simplified isort config
* - fix pkg_resources
Co-authored-by: Jens Vagelpohl <[email protected]>
isort underwent a major update, from version 4 to version 5
Zope currently pins isort to < 5.
Maybe there is a chance at next week's sprint to update the used isort version.
Also, if #891 gets accepted, I'd favor running
isort
also viapre-commit
.Just in case - this snipped would do the trick:
The text was updated successfully, but these errors were encountered: