Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update isort #892

Closed
jugmac00 opened this issue Sep 24, 2020 · 1 comment · Fixed by #910
Closed

update isort #892

jugmac00 opened this issue Sep 24, 2020 · 1 comment · Fixed by #910
Milestone

Comments

@jugmac00
Copy link
Member

jugmac00 commented Sep 24, 2020

isort underwent a major update, from version 4 to version 5

Zope currently pins isort to < 5.

Maybe there is a chance at next week's sprint to update the used isort version.

Also, if #891 gets accepted, I'd favor running isort also via pre-commit.

Just in case - this snipped would do the trick:

  - repo: https://github.com/timothycrosley/isort
    rev: 5.5.3
    hooks:
    - id: isort
@icemac icemac added this to the 5.0 milestone Sep 25, 2020
@dataflake
Copy link
Member

Just for context: The only reason isort is still pinned here is because isort 5 requires a ton of code changes. This is not complicated, just a lot of work and a lot of checking and a lot of eyeballing code changes. Those code changes are all cosmetic, so it has not been a priority. Pinning isort let's Travis stay green until someone takes the time to take this on. If you want to do it that's great.

How to run isort is an entirely separate issue. Just like with flake8 in #891 I am strongly against moving it out of tox.ini.

@icemac icemac modified the milestones: 5.0, 5.1 Oct 2, 2020
jugmac00 added a commit that referenced this issue Oct 8, 2020
dataflake added a commit that referenced this issue Oct 8, 2020
* Update `isort` to version 5.

This fixes #892

* Restore flags for `isort`

modified:   tox.ini

* Move first party imports into `known_zope`

* Use simplified isort config

* - fix pkg_resources

Co-authored-by: Jens Vagelpohl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants