Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run the production apps as the node user #6514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Dec 5, 2024

In the production image, change the owner and group of all the app files to node:node, then run the Next.js apps as node.

Please request review from @zooniverse/frontend team or an individual member of that team.

Linked Issue and/or Talk Post

How to Review

Running a bash shell in a production image, the current user should be node, not root. When you run the production Next.js apps in containers, they should still run, but as node not root.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

In the production image, change the owner and group of all the app files to `node:node`, then run the Next.js apps as `node`.
@coveralls
Copy link

Coverage Status

coverage: 77.813% (+0.02%) from 77.791%
when pulling ebfab6f on eatyourgreens:docker-image-user
into 57ccf1f on zooniverse:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] production deploys run as the root user
2 participants