Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trap errors more gracefully? #31

Open
amy-langley opened this issue Aug 23, 2017 · 1 comment
Open

trap errors more gracefully? #31

amy-langley opened this issue Aug 23, 2017 · 1 comment
Labels

Comments

@amy-langley
Copy link
Contributor

It may or may not be worth changing, but currently submitting a malformed request gets you a 500 page with a ton of detail about the error, including stack traces and some kind of WSGI console login. This could be useful for debugging but I wonder if we should clean it up somewhat for production?

@CKrawczyk
Copy link
Collaborator

I agree. Also the current page shown is only because debug mode is turned on (https://github.com/zooniverse/aggregation-for-caesar/blob/master/routs.py#L58).

Side note, this can be done in flask by adding something like

@application.errorhandler(500)
def internal_error(error):
    return "500 error"

to the application and turning off debug mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants