Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global variables dangerous for multi process / threaded servers #166

Open
camallen opened this issue Jun 13, 2019 · 0 comments
Open

Global variables dangerous for multi process / threaded servers #166

camallen opened this issue Jun 13, 2019 · 0 comments

Comments

@camallen
Copy link
Contributor

Related to #165 once running behind a multi process / threaded server the global variables won't be safe for cached data like the users and destinations variables. It may be that this works ok in multi process context but i assume the users store changes will fail in a threaded environment.

https://stackoverflow.com/questions/32815451/are-global-variables-thread-safe-in-flask-how-do-i-share-data-between-requests

This cached data should be stored in external cache system (a hosted memcache/redis instance) instead of global vars.

The same can be said for the panoptes client for re-use vs setting it up over and over again, though the client may be smart enough to avoid running the login code multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant