diff --git a/app/pages/lab/mobile/mobile-section-container.fixtures.js b/app/pages/lab/mobile/mobile-section-container.fixtures.js index 67b4220419..bbc811ab13 100644 --- a/app/pages/lab/mobile/mobile-section-container.fixtures.js +++ b/app/pages/lab/mobile/mobile-section-container.fixtures.js @@ -97,6 +97,13 @@ const validationFixtures = { }, taskFeedbackEnabled: { task: { + type: 'drawing', + tools: [ + { + type: 'rectangle', + details: [] + } + ], feedback: { enabled: true } diff --git a/app/pages/lab/mobile/mobile-section-container.jsx b/app/pages/lab/mobile/mobile-section-container.jsx index 6615977062..ccec11d803 100644 --- a/app/pages/lab/mobile/mobile-section-container.jsx +++ b/app/pages/lab/mobile/mobile-section-container.jsx @@ -101,7 +101,6 @@ function drawingTaskHasNoSubtasks({ task }) { const validatorFns = { single: { taskQuestionNotTooLong, - taskFeedbackDisabled, workflowHasSingleTask, workflowNotTooManyShortcuts: workflowHasNoMoreThanXShortcuts(2), workflowDoesNotUseGroupedSubjectSelection, @@ -109,7 +108,6 @@ const validatorFns = { }, multiple: { taskQuestionNotTooLong, - taskFeedbackDisabled, workflowHasSingleTask, workflowNotTooManyShortcuts: workflowHasNoMoreThanXShortcuts(2), workflowDoesNotUseGroupedSubjectSelection, diff --git a/app/pages/lab/mobile/mobile-section-container.spec.js b/app/pages/lab/mobile/mobile-section-container.spec.js index 68f08486c8..60fba03c3c 100644 --- a/app/pages/lab/mobile/mobile-section-container.spec.js +++ b/app/pages/lab/mobile/mobile-section-container.spec.js @@ -118,8 +118,8 @@ describe('', function () { testValidationProp('taskInstructionNotTooLong', validationFixtures.taskInstructionTooLong, false); }); - it('should check whether the task uses feedback', function () { - testValidationProp('taskFeedbackDisabled'); + it('should check whether the task uses feedback if the task type is drawing', function () { + testValidationProp('taskFeedbackDisabled', validationFixtures.workflowHasValidDrawingTask, true); testValidationProp('taskFeedbackDisabled', validationFixtures.taskFeedbackEnabled, false); }); @@ -187,7 +187,6 @@ describe('', function () { it('should equal false if any of the validations aren\'t met', function () { [ fixtures.validationFixtures.taskQuestionTooLong, - fixtures.validationFixtures.taskFeedbackEnabled, fixtures.validationFixtures.workflowHasMultipleTasks, fixtures.validationFixtures.workflowTooManyShortcuts, fixtures.validationFixtures.workflowUsesGroupedSubjectSelection