Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webstorage.utility set should give a way to handle the error #76

Open
Jiehong opened this issue Apr 10, 2019 · 0 comments
Open

webstorage.utility set should give a way to handle the error #76

Jiehong opened this issue Apr 10, 2019 · 0 comments

Comments

@Jiehong
Copy link

Jiehong commented Apr 10, 2019

Hello,

Currently, in webstorage.utility.ts, we have the following function:

public set<T>(key: string, value: T, config: DecoratorConfig = {}): T {

However, in its definition, we can see that it's only calling console.log upon failure.
This behaviour does not allow clients to detect and react in case of error.

Perhaps this function should instead return an Observable<T> or provide a callback in case of error instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants