Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAE incorrect encode function #15

Open
legin13 opened this issue Jul 11, 2015 · 1 comment
Open

RAE incorrect encode function #15

legin13 opened this issue Jul 11, 2015 · 1 comment

Comments

@legin13
Copy link

legin13 commented Jul 11, 2015

Hello! Thank you for your project, great job!

I have a trouble with encoding function in RAE. I'm new in Theano, so I could have mistaken, but I think the code in lines 51-53 is not valid: x_var should be a matrix and encode_func should contain x_var as argument, not x. So, I suppose the correct code will be:

        x_var = T.matrix()
        self._encode_func = theano.function([x_var], self.layers[0].encode_func(x_var),
                        allow_input_downcast=True, mode=theano.Mode(linker=THEANO_LINKER))

Sorry if I mistake.

@zomux
Copy link
Owner

zomux commented Jul 14, 2015

Hi,

Actually, the code for RAE is very very old, and is not well tested.

I think you are right, I have to make a testcase for it and fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants